Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] Upgrade to Blacklight 8 #4182

Closed
wants to merge 2 commits into from
Closed

[HOLD] Upgrade to Blacklight 8 #4182

wants to merge 2 commits into from

Conversation

mjgiarlo
Copy link
Member

@mjgiarlo mjgiarlo commented Sep 22, 2023 •
edited
Loading

Supersedes #2857
Closes #2857
Superseded by #4230

TO-DO

  • Fix search result pagination
  • Successfully run integration tests
  • Manually test this in a deployed env
  • Figure out if the behavior we're altering in a Blacklight.Modal.modalAjaxClickLink monkeypatch is a bug in Blacklight's modal JS or something we've got mucked up
    • Does not block merging this PR. It's a small monkeypatch and we can prioritize iterating on that change.
  • Explore whether we can remove custom EditModalComponent now that we're on Blacklight 8
    • No, our custom modal component operates via Turbo, unlike Blacklight's built-in modal component.
  • Figure out why the document_presenter helper override isn't functioning as expected
    • Fixed.

Why was this change made?

Keep pace with dependencies.

How was this change tested?

CI, local

@mjgiarlo mjgiarlo changed the title Upgrade to Blacklight 8 [HOLD] Upgrade to Blacklight 8 Sep 22, 2023
@mjgiarlo mjgiarlo marked this pull request as ready for review September 22, 2023 20:49
@mjgiarlo mjgiarlo force-pushed the blacklight8-take-two branch 4 times, most recently from 67e6a89 to 358b18a Compare September 25, 2023 21:19
@mjgiarlo mjgiarlo force-pushed the blacklight8-take-two branch from 358b18a to eeb743e Compare September 25, 2023 21:24
@mjgiarlo
Copy link
Member Author

Superseded by #4230 (rebased on main), closing.

@mjgiarlo mjgiarlo closed this Oct 11, 2023
@mjgiarlo mjgiarlo deleted the blacklight8-take-two branch October 11, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjgiarlo @ndushay